Skip to content

make-shouldNotThrowExactlyUnit-compatible-with-assertSoftly (#4808) #4809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

make-shouldNotThrowExactlyUnit-compatible-with-assertSoftly (#4808) #4809

merged 1 commit into from
Mar 28, 2025

Conversation

AlexCue987
Copy link
Member

  • make-shouldNotThrowExactlyUnit-compatible-with-assertSoftly
  • restore shouldNotThrowExactly to have its original signature, returning T not T?

This allows us to have an assertion that is compatible with assertSoftly without breaking any contracts

@AlexCue987 AlexCue987 requested a review from a team as a code owner March 14, 2025 19:02
@AlexCue987 AlexCue987 mentioned this pull request Mar 14, 2025
Closed
@sksamuel sksamuel added this pull request to the merge queue Mar 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 27, 2025
@AlexCue987 AlexCue987 added this pull request to the merge queue Mar 28, 2025
Merged via the queue into master with commit f6ef089 Mar 28, 2025
10 of 14 checks passed
@AlexCue987 AlexCue987 deleted the alex/move-to-shouldNotThrowAnyUnit branch March 28, 2025 20:24
@sksamuel sksamuel mentioned this pull request Mar 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sksamuel sksamuel sksamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexCue987 @sksamuel