Disable autoscan of config classes; Check for well known config FQN by default #4282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR disables the config lookup by classgraph scanning. |
OliverO2
approved these changes
Aug 12, 2024
|
When will this be tagged & released please? |
|
You can use the snapshot that's auto built on every merge.
…On Tue, 13 Aug 2024, 9:26 am 1Mark, ***@***.***> wrote:
When will this be tagged & released please?
—
Reply to this email directly, view it on GitHub
<#4282 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVSGRSSEVKI3V4Z5PRXTDZRIJRXAVCNFSM6AAAAABMKN4W2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBWGM4TIOJSGU>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
I love how we went back and forth on this feature over the releases |
|
I'd love to see it coming back via a compiler plugin with a zero performance penalty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3895 caused by poor performance
Fixes #4112 too possibly.
Fixes #3746