Use virtual time to test DescribeSpecExample #4232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the test coroutine scope to enable virtual time, to help make DescribeSpecExample less flaky.
|
Do you know why it's flakey atm? |
I noticed that it failed in #4218, which adds two JVM tests simultaneously. I suspect that the JVM tests running together cause delayed test launching, which triggers the timeouts. The timeouts could be increased, but I thought it would be more flexible and robust to use virtual time. This has the added benefit that the executed tests can be verified. |
sksamuel
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the test coroutine scope to enable virtual time, to help make DescribeSpecExample less flaky.
Part of #4113