Skip to content

Conversation

sksamuel
Copy link
Member

@sksamuel sksamuel commented Jul 21, 2024

As part of 6.0 all deprecated methods are being removed.

@sksamuel sksamuel requested review from Kantis, aSemy and OliverO2 July 21, 2024 19:15
@sksamuel sksamuel added this to the 6.0 milestone Jul 21, 2024
@sksamuel sksamuel enabled auto-merge July 21, 2024 19:23
@sksamuel sksamuel requested a review from LeoColman July 21, 2024 19:26
Copy link
Contributor

@OliverO2 OliverO2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit hard to review, but at least I could not find any obvious problems. Just seems that the lexicographic order of import statements is now broken.

@sksamuel
Copy link
Member Author

A bit hard to review, but at least I could not find any obvious problems. Just seems that the lexicographic order of import statements is now broken.

I've just moved things about, no code changes.

Is there a setting in intellij for the order ?

@OliverO2
Copy link
Contributor

Is there a setting in intellij for the order ?

I'm not sure, I'm using the Ktlint plugin with auto-formatting on save for my own stuff. That one does ordering. I suppose IntelliJ by default does that, too, as it has also settings on whether to accept star imports and such.

@sksamuel sksamuel added this pull request to the merge queue Jul 21, 2024
@sksamuel
Copy link
Member Author

Is there a setting in intellij for the order ?

I'm not sure, I'm using the Ktlint plugin with auto-formatting on save for my own stuff. That one does ordering. I suppose IntelliJ by default does that, too, as it has also settings on whether to accept star imports and such.

I have star imports disabled.

@OliverO2
Copy link
Contributor

Yeah, me too. Just mentioned it to support my suspicion that IJ can be pretty opinionated wrt. imports.

Merged via the queue into master with commit 6a6e353 Jul 21, 2024
7 checks passed
@sksamuel sksamuel deleted the sks/simplify3 branch July 21, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants