Skip to content

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Jun 22, 2024

Currently CI has to complete tests on Ubuntu before starting macOS and Windows test. This adds ~20 minutes to the CI run.

This PR runs tests in all PRs in parallel, immediately. This will reduce the duration of testing PRs and the merge queue.

@aSemy aSemy requested a review from OliverO2 June 22, 2024 08:20
Copy link
Contributor

@OliverO2 OliverO2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, if it helps to advance, a good thing. In the future, if we're seeing mostly positive results, which I'm hoping, I'll remain in favor. Otherwise we might consider to change back and avoid wasting resources.

@aSemy
Copy link
Contributor Author

aSemy commented Jun 22, 2024

For now, if it helps to advance, a good thing. In the future, if we're seeing mostly positive results, which I'm hoping, I'll remain in favor. Otherwise we might consider to change back and avoid wasting resources.

Sounds good, we can always revisit it.

Once the tests are most stable, another option is to set fail-fast: true

@aSemy aSemy merged commit bcafbf8 into master Jun 22, 2024
@aSemy aSemy deleted the adam/feat/gha-parallel-test-os branch June 22, 2024 11:39
@sksamuel
Copy link
Member

Currently CI has to complete tests on Ubuntu before starting macOS and Windows test. This adds ~20 minutes to the CI run.

This PR runs tests in all PRs in parallel, immediately. This will reduce the duration of testing PRs and the merge queue.

This was done on purpose because macos runners are limited to I think 2 concurrent runs.

Since most failures are in the common layer, tying up the mac runners when your linux build fails, is a waste of the mac resources.

@aSemy aSemy added the builds 🐘 PRs / Issues related to the CI/CD pipelines or Gradle builds label Jun 24, 2024
@aSemy
Copy link
Contributor Author

aSemy commented Jun 28, 2024

This was done on purpose because macos runners are limited to I think 2 concurrent runs.

I haven't heard of that restriction before, and I couldn't find anything in the docs. Perhaps it's an old restriction, and it's been lifted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds 🐘 PRs / Issues related to the CI/CD pipelines or Gradle builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants