Skip to content

Publish Kotest KMP Gradle Plugin to Maven Central #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2024
Merged

Publish Kotest KMP Gradle Plugin to Maven Central #4136

merged 2 commits into from
Jul 9, 2024

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Jun 20, 2024

Resolves #4012

@aSemy aSemy force-pushed the adam/feat/kotest-gradle-plugin-publish branch 2 times, most recently from 4395986 to ef6cb3d Compare June 22, 2024 10:55
@aSemy aSemy force-pushed the adam/feat/kotest-gradle-plugin-publish branch from ef6cb3d to e3ef819 Compare June 22, 2024 11:44
@Kantis Kantis added the builds 🐘 PRs / Issues related to the CI/CD pipelines or Gradle builds label Jun 24, 2024
@aSemy aSemy requested review from sksamuel and OliverO2 July 9, 2024 20:30
OliverO2
OliverO2 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@OliverO2 OliverO2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this "just works". Could this be tested somehow outside GH CI?

@aSemy
Copy link
Contributor Author

aSemy commented Jul 9, 2024

I assume this "just works". Could this be tested somehow outside GH CI?

Hmmmm I guess the only way to really test it is to try publishing to Maven Central snapshots!

Publishing in general can be tested by running ./gradlew publishAllPublicationsToRootBuildDirRepository, and check $rootDir/build/maven-repo/. But that won't test misc publishing config, like signing (unless you have some valid signing config set up.)

@OliverO2
Copy link
Contributor

OliverO2 commented Jul 9, 2024

Wouldn't that change also push the KMP Gradle plugin to Sonatype snapshots? Either way, I'd say let's just try and fail forward if anything breaks.

@aSemy aSemy merged commit ee884fc into master Jul 9, 2024
@aSemy aSemy deleted the adam/feat/kotest-gradle-plugin-publish branch July 9, 2024 22:11
@OliverO2 OliverO2 mentioned this pull request Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliverO2 OliverO2 OliverO2 approved these changes

@sksamuel sksamuel Awaiting requested review from sksamuel

Assignees
No one assigned
Labels
builds 🐘 PRs / Issues related to the CI/CD pipelines or Gradle builds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kotest Gradle plugin is missing in snapshot publications
3 participants
@aSemy @OliverO2 @Kantis