Fix kotest-framework-multiplatform-plugin-gradle build #4117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Define an input dependency for the task `updateKotestPluginConstants`, to prevent Gradle from skipping it with "NO-SOURCE". * Avoid failing the build with an undefined symbol "KOTEST_COMPILER_PLUGIN_VERSION". * Make the delete task compatible with the configuration cache.
Otherwise: > Inconsistent JVM-target compatibility detected for tasks 'compileJava' (17) and 'compileKotlin' (1.8).
|
Oh, interesting! Good catch. I guess that TextResource isn't compatible with configuration cache. |
|
With the dedicated task class, there was no longer a need for |
|
Do you mind if I refactor it to use the dynamic task dsl? I find it more appropriate for tasks that are defined in a build script. val updateKotestPluginConstants by tasks.registering {
val kotestPluginConstants = """
|// Generated file, do not edit manually
|@file:org.gradle.api.Generated
|
|package io.kotest.framework.multiplatform.gradle
|
|const val KOTEST_COMPILER_PLUGIN_VERSION: String = "${Ci.gradleVersion}"
|
""".trimMargin()
inputs.property("kotestPluginConstants", kotestPluginConstants)
val outputDir = layout.buildDirectory.dir("generated/src/main/kotlin/")
outputs.dir(outputDir).withPropertyName("outputDir")
doLast {
val kotestPluginConstantsFile = outputDir.get().asFile
.resolve("io/kotest/framework/multiplatform/gradle/kotestPluginConstants.kt")
kotestPluginConstantsFile.apply {
parentFile.deleteRecursively()
parentFile.mkdirs()
writeText(kotestPluginConstants)
}
}
}
kotlin.sourceSets.main {
kotlin.srcDir(updateKotestPluginConstants)
}(GitHub won't let me add this as a code suggestion) Otherwise, I'd prefer moving the class-based task into buildSrc. |
|
No, I don't mind at all. That's what I've tried to achieve first. Just could not find the |
aSemy
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateKotestPluginConstants, to prevent Gradle from skipping it with "NO-SOURCE".cleantask compatible with the configuration cache.