Skip to content

Tidy kotest-common logger #4080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2024
Merged

Tidy kotest-common logger #4080

merged 3 commits into from
Jun 9, 2024

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Jun 9, 2024 •
edited
Loading

  • Annotate vals/funs with @KotestInternal to avoid opt-in warnings
  • Remove @OverloadResolutionByLambdaReturnType from log function (it has no overloads)

I saw that the failure in this build had an error relating to the logger functions, so maybe tidying it up will help.

org.gradle.api.internal.tasks.testing.TestSuiteExecutionException: Could not complete execution for Gradle Test Executor 1.
	[...]
Caused by: org.junit.platform.commons.JUnitException: TestEngine with ID 'kotest' failed to discover tests
	[...]
Caused by: java.lang.NoSuchMethodError: 'void io.kotest.mpp.Logger.logsimple(kotlin.jvm.functions.Function0)'
	at io.kotest.runner.junit.platform.KotestJunitPlatformTestEngine.discover(KotestJunitPlatformTestEngine.kt:101)
	at io.kotest.runner.junit.platform.KotestJunitPlatformTestEngine.discover(KotestJunitPlatformTestEngine.kt:35)
	at org.junit.platform.launcher.core.EngineDiscoveryOrchestrator.discoverEngineRoot(EngineDiscoveryOrchestrator.java:152)
	... 28 more

@Kantis Kantis added this pull request to the merge queue Jun 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 9, 2024
@Kantis Kantis added this pull request to the merge queue Jun 9, 2024
Merged via the queue into kotest:master with commit b55bcf3 Jun 9, 2024
@aSemy aSemy deleted the fix/tidy-logger branch June 9, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kantis Kantis Kantis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aSemy @Kantis @sksamuel