Refactor KMP POM rewriting #4072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of editing the POM in-memory, instead modify the POM file that the `generatePomFileForKotlinMultiplatformPublication` task produces. Replace the Groovy XML utils with W3C Document classes, because the Groovy XML utils don't preserve comments.
Kantis
approved these changes
Jun 8, 2024
|
Nice work @aSemy 🚀 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update KMP POM re-writer to be CC compatible.
Instead of editing the POM in-memory, instead modify the POM file that the
generatePomFileForKotlinMultiplatformPublicationtask produces.Replace the Groovy XML utils with W3C Document classes, because the Groovy XML utils don't preserve comments.
I added a project-local Maven repository, for easier testing of the changes. Run
./gradlew publishAllPublicationsToRootBuildDirRepositoryand checkbuild/maven-repo.Relates to