Skip to content

Remove @ExperimentalStdlibApi annotation from testCoroutineScheduler #4075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2024
Merged

Remove @ExperimentalStdlibApi annotation from testCoroutineScheduler #4075

merged 1 commit into from
Jun 13, 2024

Conversation

osipxd
Copy link
Contributor

@osipxd osipxd commented Jun 8, 2024

In addition to #4070

Implementation of testCoroutineScheduler extension could be changed to avoid @ExperimentalStdlibApi annotation

@osipxd
Copy link
Contributor Author

osipxd commented Jun 13, 2024 •
edited
Loading

CI failure looks unrelated to my changes. And locally all tests are green. @Kantis, could you please try to rerun the test job?

com.sksamuel.kotest.runner.junit5.PerformanceTest[jvm]

  Test performance of multiple tests[jvm] FAILED (3s)

  org.junit.platform.commons.JUnitException: TestEngine with ID 'kotest' failed to discover tests
  Caused by: org.junit.platform.commons.JUnitException: TestEngine with ID 'kotest' failed to discover tests
  Caused by: io.kotest.engine.config.ConfigurationException: io.github.classgraph.ClassGraphException: Uncaught exception during scan
  Caused by: io.github.classgraph.ClassGraphException: Uncaught exception during scan
  Caused by: java.lang.OutOfMemoryError: Java heap space

OliverO2
OliverO2 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@OliverO2 OliverO2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I also like the duration cleanup!

@OliverO2 OliverO2 added this pull request to the merge queue Jun 13, 2024
Merged via the queue into kotest:master with commit b343a5b Jun 13, 2024
@osipxd osipxd deleted the feature/remove-experimental-from-testCoroutineScheduler branch June 13, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliverO2 OliverO2 OliverO2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osipxd @OliverO2