Skip to content

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Jun 6, 2024

prevent false-positive CC errors from failing the build #4062 (comment)

prevent false-positive CC errors from failing the build kotest#4062 (comment)
@aSemy aSemy marked this pull request as ready for review June 6, 2024 09:05
@aSemy
Copy link
Contributor Author

aSemy commented Jun 6, 2024

This PR is a quick fix - a more robust fix would be fixing publishPlatformArtifactsInRootModule() to be CC compliant, so that notCompatibleWithConfigurationCache() isn't necessary

// Disable Config Cache to prevent error:
// Task `:[...]:generatePomFileForKotlinMultiplatformPublication` of type `GenerateMavenPom`:
// cannot serialize object of type 'DefaultMavenPublication', a subtype of 'Publication',
// as these are not supported with the configuration cache.
notCompatibleWithConfigurationCache("publishPlatformArtifactsInRootModule")

Alternative, wait until Gradle fixes it gradle/gradle#22481

@Kantis Kantis enabled auto-merge June 8, 2024 09:14
@Kantis Kantis added this pull request to the merge queue Jun 8, 2024
Merged via the queue into kotest:master with commit 51c1c0e Jun 8, 2024
@aSemy aSemy deleted the patch-1 branch June 8, 2024 10:03
@aSemy aSemy added the builds 🐘 PRs / Issues related to the CI/CD pipelines or Gradle builds label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds 🐘 PRs / Issues related to the CI/CD pipelines or Gradle builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants