feat(maven): improve experience for multimodule project #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
|
That's great. Learned a lot from your changes. 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #94.
But not exactly, cause Maven plugin inheritance (under multi-module project) is far more complicated then I ever think of.
For example, this patch works well if you configure the plugin in the parent module and run
mvn hawkeye:check. But what if you want to bind it with VERIFY phase? The plugin will be inherited into all of the children modules and they will resolve relative path incorrectly. (Although we can supportskipand skip at all the children modules as we do for the exec goal under the root pom.xml file in this project.)We should spend some time to investigate what is the proper best practice here. And this PR serves as a reference instead of a mergeable patch.
cc @spencercjh