Skip to content

deps: Remove Go patch version from go.mods #4292

@kaovilai

Description

@kaovilai

kopia/go.mod

Line 3 in a9674bc

go 1.22.7

came in via
#4103
coming from grpc/grpc-go#7624
which have since been reverted in grpc/grpc-go#7831 which I hope will be available in the next version.

I would ask that kopia remove the patch go version to reduce import impacts such as those seen in vmware-tanzu/velero#8472 as of vmware-tanzu/velero@3cd85f5

We would like it back to

kopia/go.mod

Line 3 in befa16e

go 1.22

The issue with specifying the patch version that is not 0 is that now all modules that import this module will have to use this or a newer version. There may be reasons people don't or cannot use the more recent patch version. FWIW I think a library shouldn't have an opinion on the patch version used.

We need this for vmware-tanzu/velero#8397
same reason as in grpc/grpc-go#7624 (comment)

Example

❯ go get go@1.22.0 toolchain@none
go: downloading google.golang.org/grpc v1.68.0-dev
go: downgraded go 1.22.7 => 1.22.0
go: downgraded google.golang.org/grpc v1.68.0 => v1.68.0-dev #ideally wait for -dev to become 1.68.1

cc: @ShellyKa13 @blackpiglet @Lyndon-Li

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions