Fix MyAnimeList Token Refresh #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodjodevf
approved these changes
Jul 27, 2025
kodjodevf
approved these changes
Jul 27, 2025
kodjodevf
approved these changes
Jul 27, 2025
kodjodevf
approved these changes
Jul 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issue:
When the user logged in with mobile, the mobile clientId was being used to login. When the token expires and the user is now on desktop, the desktop clientId will be used to get the new token, leading to a
{"error":"invalid_request","message":"The refresh token is invalid.","hint":"Token is not linked to client"}response from MAL.Now the used clientId is being saved on login in the OAuth model and is being used when refreshing the token.
If the user logged in before this change, and therefore
OAuth.clientIdis null, the clientId for the current platform will be tried to get the refresh token. If it fails, it will fallback to the other clientId.If that also fails, it will log the user out of MAL with the botToast message "MyAnimeList Token expired".
Also refactored the code a little to reduce some duplication and enhance readability.