Fix regression: restore fullscreen exit logic on desktop #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was unintentionally removed in d21dbbb. This caused fullscreen mode to persist when the user exited the anime player view before the video had started loading. The fullscreen now correctly exits in the dispose method for desktop platforms again.
89adca7 to
b388c5f
Compare
kodjodevf
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a mistake from commit d21dbbb where the fullscreen reset logic was accidentally removed from
AnimePlayerView.dispose().As a result, the app remained stuck in fullscreen mode when exiting the anime player view before a video had loaded.
The call to setFullScreen(...) has been re-added to restore the original behavior.