Fix versioning and packaging issues for Windows and Linux builds; improve packaging consistency #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By not passing --app-version or the Flutter build flags at all, inno_bundle will read the pubspec.yaml and pass `--build-name 0.6.3 --build-number 85` down into `flutter build windows` And stamp both the EXE’s PE resource and the Inno Setup installer with that exact version.
https://pub.dev/documentation/flutter_distributor/latest/ > **Important Notice**: flutter_distributor has been renamed to [fastforge](https://github.com/fastforgedev/fastforge). You can continue to use flutter_distributor, but we recommend migrating to fastforge for the latest features and updates. Please visit https://fastforge.dev for more information.
and add required dependencies
linuxdeploy automatically grabs the required libraries for Mangayomi and packs them into the AppImage.
fastforge always generates a .desktop file with incorrect semantics. The generated .desktop file incorrectly includes a 'Version' key, which is not part of the freedesktop.org specification. fastforgedev/fastforge#158
instead of Git tag
kodjodevf
approved these changes
Jul 11, 2025
kodjodevf
approved these changes
Jul 11, 2025
kodjodevf
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several issues with the Windows and Linux build and release workflows, improving version handling, packaging consistency, and correctness of desktop integration.
Summary of changes:
Windows:
--app-versionargument from theinno_bundlebuild command (previously it was showing 1.0.0)Linux RPM package:
pubspec.yamlfor RPM packaging, fixing the previous hardcoded version issue (1.0.0).Linux AppImage:
appimagetoolwithlinuxdeployto bundle all required libraries and make the AppImage fully self-contained.imagemagick(convert) to ensure icon consistency.Linux DEB package:
flutter_distributorwith the newerfastforgetool for deb package creation.linux/packaging/deb/make_configto adjust installed size and include necessary dependencies.Additionally, all Linux builds now use the same
.desktopfile. The auto-generated.desktopfile created byfastforge(formerlyflutter_distributor) includes a 'Version' key, which is not part of the freedesktop.org specification. To my knowledge it is not possible to disable that and provide a custom one directly. That's why we have to repackage it.