Fixes, Refactors, and Async Improvements #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Exception has occurred. ArgumentError (Invalid argument(s): No host specified in URI ) ``` at line 79: `final req = await http.get(Uri.parse(source.sourceCodeUrl!));` when source.sourceCodeUrl is empty.
Mixing `writeTxnSync` with `await` was incorrect. writeTxnSync does not support awaiting async functions.
There was a bug when uninstalling an extension and trying to reinstall it, it didn't install. You had to restart the app to reinstall the same extension again. Now the provider is invalidated when reinstalling an uninstalled extension, so the fetch logic is triggered correctly. Prevents stale cache issues from Riverpod's keepAlive behavior.
Merge `fetchMangaSourcesListProvider`, `fetchAnimeSourcesListProvider` and `fetchNovelSourcesListProvider` into a single Provider, `FetchItemSourcesListProvider`, reducing code duplication.
kodjodevf
approved these changes
Jun 7, 2025
kodjodevf
approved these changes
Jun 7, 2025
kodjodevf
approved these changes
Jun 7, 2025
kodjodevf
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several improvements and bug fixes:
✅ Fixes
fetch_sources_list.dartPrevents an exception when
source.sourceCodeUrlis empty. Now gracefully handles empty URLs to avoid:Fixed an issue where an extension couldn't be reinstalled after being uninstalled unless the app was restarted.
The provider is now correctly invalidated, allowing Riverpod to trigger fresh fetch logic and avoid stale cache due to
keepAlive.Before:
before.mp4
After:
after.mp4
🔄 Refactor
Combined
fetchMangaSourcesListProvider,fetchAnimeSourcesListProvider, andfetchNovelSourcesListProviderinto a unifiedFetchItemSourcesListProvider, reducing redundancy and improving maintainability.🧵 Async Improvements
Replaced incorrect usage of:
with a fully async approach.
Mixing writeTxnSync with await was invalid and could cause undefined behavior.