Improve Video Playback UI & Maintainability #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent an AssertionError in the Slider widget when the skip duration
button causes the value to exceed the video's maximum duration.
Clamp the Slider's value to the range [0, max]
using `clamp(0.0, maxValue).toDouble()` to ensure it stays within bounds.
Exception example:
```
Exception has occurred.
_AssertionError ('package:flutter/src/material/slider.dart': Failed assertion: line 199 pos 10: 'value >= min && value <= max': Value 1410000.0 is not between minimum 0.0 and maximum 1409533.0)
```
Fix playback time display exceeding max duration when skipping near video end
Extract `CustomMaterialPlayOrPauseButton` class from *mobile.dart* and `CustomMaterialDesktopPlayOrPauseButton` class from *desktop.dart* into *play_or_pause_button.dart* to eliminate code duplication and improve maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several improvements to the video playback experience and code maintainability:
Code Quality Enhancements:
anime_player_view.dartby introducing a helper method for_mobileBottomButtonBar()and_desktopBottomButtonBar().CustomMaterialPlayOrPauseButtonclass frommobile.dartanddesktop.dartinto a separate file to eliminate redundant implementations.Bug Fixes:
custom_seekbar.dartwhen skipping beyond the video duration, ensuring the slider value remains within valid bounds.desktop.dartwhere playback time exceeded the maximum duration when skipping near the end of a video.Feature Additions:
anime_player_view.dartfor adjusting video playback speed, so the user doesn't have to cycle through all speed-options.Infrastructure Updates:
release.ymlto fetch the latestappimagetool, instead of the obsolete version.