Skip to content

[#965]: Document other body types #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2018
Merged

[#965]: Document other body types #1285

merged 2 commits into from
Dec 12, 2018

Conversation

doug-wade
Copy link
Contributor

Fixes #965

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #1285 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1285   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           5       5           
  Lines         395     395           
======================================
  Hits          395     395

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 281a04e...354485d. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 7, 2018 •
edited
Loading

Codecov Report

Merging #1285 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1285   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           5       5           
  Lines         395     393    -2     
======================================
- Hits          395     393    -2
Impacted Files Coverage Δ
lib/request.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 281a04e...7f1236d. Read the comment docs.

@doug-wade
Copy link
Contributor Author

Credit to @jonathanong who wrote the majority of the copy -- thanks!

fl0w
fl0w approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@fl0w fl0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(nit suggestion, take it or leave it)

@fl0w @doug-wade
Update docs/api/response.md
7f1236d 
Co-Authored-By: doug-wade <douglas.b.wade@gmail.com>
@dead-horse dead-horse merged commit 48993ad into koajs:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead-horse dead-horse dead-horse approved these changes

+1 more reviewer

@fl0w fl0w fl0w approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doug-wade @fl0w @dead-horse