fix: only allow back redirect to the same origin referer #1898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a security vulnerability related to redirect handling in Koa.js by restricting "back" redirects to only allow same-origin referrers, preventing potential open redirect attacks.
Key changes:
- Adds validation logic to check if referrer URLs are from the same origin before allowing redirects
- Introduces a new private method
_getBackReferrer()to safely handle referrer validation - Updates tests to verify the new same-origin validation behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/response.js | Implements same-origin validation for "back" redirects with new _getBackReferrer() method |
| tests/response/redirect.js | Adds test cases to verify same-origin referrer validation works correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHSA-jgmv-j7ww-jx2x
close #1892
close #1897