Skip to content

feat: replace debug module with pure node:util::debuglog #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2025
Merged

feat: replace debug module with pure node:util::debuglog #1885

merged 2 commits into from
Jun 5, 2025
+60 −61

Conversation

3imed-jaberi
Copy link
Member

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@3imed-jaberi 3imed-jaberi requested a review from jonathanong June 5, 2025 11:57
@3imed-jaberi 3imed-jaberi self-assigned this Jun 5, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (8620ced) to head (b2b053a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1885      +/-   ##
==========================================
- Coverage   99.90%   99.90%   -0.01%     
==========================================
  Files           9        9              
  Lines        2049     2046       -3     
==========================================
- Hits         2047     2044       -3     
  Misses          2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@3imed-jaberi 3imed-jaberi force-pushed the replace-debug-with-native-node-equivalent branch from be24faa to 65b4f47 Compare June 5, 2025 11:58
@3imed-jaberi 3imed-jaberi requested a review from titanism June 5, 2025 12:08
@titanism titanism mentioned this pull request Jun 5, 2025
Merged
6 tasks
@jonathanong
Copy link
Member

let's try to limit changes in PRs to that described in the PR title :) lots of style changes we can do separately

@3imed-jaberi 3imed-jaberi merged commit 2f6e814 into master Jun 5, 2025
6 checks passed
@3imed-jaberi 3imed-jaberi deleted the replace-debug-with-native-node-equivalent branch June 5, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanong jonathanong jonathanong approved these changes

@titanism titanism titanism approved these changes

Assignees

@3imed-jaberi 3imed-jaberi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3imed-jaberi @jonathanong @titanism