Skip to content

Now URIResolver can resolve KReference.Group #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Now URIResolver can resolve KReference.Group #2179

wants to merge 2 commits into from

Conversation

slinkydeveloper
Copy link
Contributor

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Part of knative/eventing#5086

Changes

@slinkydeveloper
Now URIResolver can resolve kreference group
e5aa1a4 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 5, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 5, 2021
@slinkydeveloper
Copy link
Contributor Author

cc @n3wscott

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: slinkydeveloper
To complete the pull request process, please assign n3wscott after the PR has been reviewed.
You can assign the PR to them by writing /assign @n3wscott in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slinkydeveloper slinkydeveloper mentioned this pull request Jul 5, 2021
Open
11 tasks
@codecov
Copy link

codecov bot commented Jul 5, 2021 •
edited
Loading

Codecov Report

Merging #2179 (29ba44c) into main (51cfaab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2179   +/-   ##
=======================================
  Coverage   66.05%   66.05%           
=======================================
  Files         224      224           
  Lines        9426     9434    +8     
=======================================
+ Hits         6226     6232    +6     
- Misses       2920     2921    +1     
- Partials      280      281    +1
Impacted Files Coverage Δ
resolver/addressable_resolver.go 95.74% <100.00%> (+0.39%) ⬆️
test/gcs/mock/mock.go 90.32% <0.00%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f9568...29ba44c. Read the comment docs.

@slinkydeveloper
lint issue
29ba44c 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot
Copy link
Contributor

@slinkydeveloper: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2021
@dprotaso
Copy link
Member

closing since slinky has moved on from Knative

@dprotaso dprotaso closed this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slinkydeveloper @knative-prow-robot @dprotaso