Skip to content

feat: base image flag for host builds #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

gauron99
Copy link
Contributor

Changes

  • add --base-image flag for build/deploy/run for specifying the base image that function will be built upon (host builder only)

/kind enhancement

Release Note

add --base-image flag to override the base image for host builds

@knative-prow knative-prow bot requested review from dsimansk and jrangelramos July 11, 2025 15:06
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2025
@gauron99 gauron99 force-pushed the push-vsqnxtplwvvu branch from e635b92 to 7fa6bd1 Compare July 11, 2025 15:07
@gauron99 gauron99 requested review from matejvasek and lkingland and removed request for dsimansk and jrangelramos July 11, 2025 15:08
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 60.72%. Comparing base (589bbe8) to head (0db6ac6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/oci/python_builder.go 0.00% 4 Missing ⚠️
pkg/oci/builder.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2935      +/-   ##
==========================================
+ Coverage   59.95%   60.72%   +0.76%     
==========================================
  Files         130      130              
  Lines       16604    16626      +22     
==========================================
+ Hits         9955    10096     +141     
+ Misses       5723     5574     -149     
- Partials      926      956      +30     
Flag Coverage Δ
e2e-tests 41.75% <58.06%> (+1.40%) ⬆️
integration-tests 55.41% <83.87%> (+1.77%) ⬆️
unit-tests 47.47% <83.87%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 force-pushed the push-vsqnxtplwvvu branch from 7fa6bd1 to deef117 Compare July 11, 2025 15:20
@gauron99 gauron99 force-pushed the push-vsqnxtplwvvu branch from deef117 to 0db6ac6 Compare July 11, 2025 18:19
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
Copy link

knative-prow bot commented Jul 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 211df16 into knative:main Jul 11, 2025
39 checks passed
@gauron99 gauron99 deleted the push-vsqnxtplwvvu branch July 14, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants