Skip to content

fix: refer correct version of schema in func.yaml #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

fix: refer correct version of schema in func.yaml #2924

merged 1 commit into from
Jul 8, 2025

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jul 8, 2025 •
edited
Loading

Changes

  • Refer correct version of schema in func.yaml. Before we erroneously referred specversion, not git reference (branch/tag/hash).
  • Moved version info into separate package to break cyclical dependency.

/kind bug

fix: refer correct version of schema in func.yaml

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 8, 2025
@matejvasek matejvasek requested a review from lkingland July 8, 2025 12:08
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2025
@knative-prow knative-prow bot requested review from jrangelramos and vyasgun July 8, 2025 12:08
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2025
@matejvasek matejvasek requested review from matzew and gauron99 and removed request for vyasgun July 8, 2025 12:09
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.05%. Comparing base (630064c) to head (a8fb64a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/functions/function.go 84.21% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2924      +/-   ##
==========================================
+ Coverage   59.25%   61.05%   +1.80%     
==========================================
  Files         130      130              
  Lines       16490    16505      +15     
==========================================
+ Hits         9771    10077     +306     
+ Misses       5822     5472     -350     
- Partials      897      956      +59
Flag Coverage Δ
e2e-tests 41.98% <86.36%> (+7.87%) ⬆️
integration-tests 55.70% <72.72%> (+1.76%) ⬆️
unit-tests 47.70% <72.72%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek matejvasek force-pushed the fix-schemaversion-ref branch from 6baf68c to d5ff4cd Compare July 8, 2025 12:15
@matejvasek
fix: refer correct version of schema in func.yaml
a8fb64a 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek force-pushed the fix-schemaversion-ref branch from d5ff4cd to a8fb64a Compare July 8, 2025 12:22
@matejvasek
Copy link
Contributor Author

PTAL @lkingland @gauron99 @jrangelramos

@jrangelramos
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025
@knative-prow knative-prow bot merged commit 6a3ef46 into knative:main Jul 8, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland Awaiting requested review from lkingland

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@matzew matzew Awaiting requested review from matzew

@gauron99 gauron99 Awaiting requested review from gauron99

Assignees

@jrangelramos jrangelramos

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejvasek @jrangelramos