-
Notifications
You must be signed in to change notification settings - Fork 156
fix: Python local buildpack build #2907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b1a78bc
to
4a3a1a0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2907 +/- ##
==========================================
+ Coverage 60.74% 61.24% +0.49%
==========================================
Files 129 130 +1
Lines 16330 16406 +76
==========================================
+ Hits 9920 10048 +128
+ Misses 5481 5400 -81
- Partials 929 958 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4a3a1a0
to
8343efd
Compare
Signed-off-by: Matej Vašek <mvasek@redhat.com>
8343efd
to
92c6fe5
Compare
Signed-off-by: Matej Vašek <mvasek@redhat.com>
92c6fe5
to
2b62e93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm !
You say hacky, I say brilliant. Thanks Matej!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
pack
build.Local
pack
build was not working because of absent scaffolding. Fix is done by doing scaffolding in docker client (that is passed into constructor ofpack
client). Basically our custom docker client hijacks tar stream and alters it. It moves content of/workspace/
into/workspace/fn
and then puts scaffolding directly into/workspace
, the scaffolding then refers handler in./fn
.So when
pack
clients tires to upload something like:The actual content pushed to container is:
The thing is that the
Python
paketo buildpack (as opposed toNode
orGo
) does not allow build form sub-directory, the project must be in workspace root.This is just temporary hacky solution, we should come up with something better in future.
LISTEN_ADDRESS
default for local pack build/kind bug