Skip to content

feat: Python,Go func listen dual-stack #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2025
Merged

feat: Python,Go func listen dual-stack #2898

merged 2 commits into from
Jul 1, 2025

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jun 30, 2025 •
edited
Loading

Changes

  • 🎁 Python and Go function listen dualstack.
    On Linux listening on [::] also listen on 0.0.0.0.

/kind enhancement

feat: Python and Go function listen dualstack

@matejvasek
feat: py func listen dual-stack
ccee586 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added kind/enhancement approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 30, 2025
@knative-prow knative-prow bot requested review from dsimansk and nainaz June 30, 2025 09:26
@matejvasek matejvasek requested review from lkingland and removed request for dsimansk and nainaz June 30, 2025 09:26
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 30, 2025
@matejvasek
Copy link
Contributor Author

@jrangelramos could you please test this on OCP?

@codecov Codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.50%. Comparing base (56e1b0f) to head (e8c5342).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/oci/python_builder.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2898      +/-   ##
==========================================
+ Coverage   59.25%   61.50%   +2.24%     
==========================================
  Files         129      129              
  Lines       16246    16312      +66     
==========================================
+ Hits         9626    10032     +406     
+ Misses       5722     5323     -399     
- Partials      898      957      +59
Flag Coverage Δ
e2e-tests 42.33% <0.00%> (+1.31%) ⬆️
integration-tests 48.00% <66.66%> (?)
unit-tests 48.14% <66.66%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek matejvasek changed the title feat: py func listen dual-stack feat: Python,Go func listen dual-stack Jun 30, 2025
@matejvasek
fix: Go host built image listens on any iface
e8c5342 
Previously it was listening only on localhost

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek requested review from matzew and gauron99 June 30, 2025 12:23
@matejvasek
Copy link
Contributor Author

PTAL @lkingland

lkingland
lkingland approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 65de4ac into knative:main Jul 1, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland lkingland approved these changes

@matzew matzew Awaiting requested review from matzew

@gauron99 gauron99 Awaiting requested review from gauron99

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejvasek @lkingland