feat: add labels to func describe #2882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4a7423 to
220cc32
Compare
220cc32 to
02a8e80
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2882 +/- ##
==========================================
+ Coverage 59.70% 61.50% +1.80%
==========================================
Files 129 129
Lines 16312 16328 +16
==========================================
+ Hits 9739 10043 +304
+ Misses 5673 5327 -346
- Partials 900 958 +58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0fee7ce to
9024984
Compare
9024984 to
e4ef665
Compare
return typed error on describe of uninitialized Function adds describe tests
e4ef665 to
4547baf
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "Labels" section to describe command's output.
/kind enhancement
Note that, as with the other
func config ...commands, adding unit tests is not possible without a refactor. The forthcoming E2E tests do test these features, and unit tests will be added when these subcommands are refactored to match the testability of the other commands.