Skip to content

feat: add noninteractive path to func config envs remove #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

feat: add noninteractive path to func config envs remove #2879

merged 1 commit into from
Jun 27, 2025

Conversation

lkingland
Copy link
Member

/kind enhancement

func config remove now supports noninteractive usecases via a --name flag

@knative-prow knative-prow bot requested review from dsimansk and nainaz June 24, 2025 08:52
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review.

Project coverage is 62.81%. Comparing base (1cccfd3) to head (fa88094).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
cmd/config_envs.go 36.36% 12 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2879      +/-   ##
==========================================
+ Coverage   57.96%   62.81%   +4.84%     
==========================================
  Files         129      129              
  Lines       15767    15784      +17     
==========================================
+ Hits         9140     9915     +775     
+ Misses       5785     4924     -861     
- Partials      842      945     +103
Flag Coverage Δ
e2e-tests 43.22% <36.36%> (+8.04%) ⬆️
integration-tests 48.97% <27.27%> (?)
unit-tests 49.07% <27.27%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gauron99
gauron99 approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ffd997c into knative:main Jun 27, 2025
39 of 40 checks passed
@lkingland lkingland deleted the push-lzumvpllmxyp branch June 30, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauron99 gauron99 gauron99 approved these changes

@dsimansk dsimansk Awaiting requested review from dsimansk

@nainaz nainaz Awaiting requested review from nainaz

Assignees

@gauron99 gauron99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkingland @gauron99