Skip to content

feat: support FUNC_GIT env in Host builder #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

lkingland
Copy link
Member

Changes

  • 🎁 Adds FUNC_GIT env support to the Host builder

Allow specifying the path to git when using the Host builder via the FUNC_GIT environment variable.

/kind enhancement

Release Note

The path to git can be altered from that in PATH by using the FUNC_GIT environment variable when using the host builder.

Docs


@knative-prow knative-prow bot added kind/enhancement size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2025
@knative-prow knative-prow bot requested review from jrangelramos and vyasgun June 24, 2025 05:22
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.88%. Comparing base (1cccfd3) to head (86e9457).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2876      +/-   ##
==========================================
+ Coverage   57.96%   62.88%   +4.91%     
==========================================
  Files         129      129              
  Lines       15767    15776       +9     
==========================================
+ Hits         9140     9921     +781     
+ Misses       5785     4912     -873     
- Partials      842      943     +101     
Flag Coverage Δ
e2e-tests 43.23% <0.00%> (+8.04%) ⬆️
integration-tests 49.04% <100.00%> (?)
unit-tests 49.14% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2025
Copy link

knative-prow bot commented Jun 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit b31a3a4 into knative:main Jun 27, 2025
39 checks passed
@lkingland lkingland deleted the push-mklooylvqpxw branch June 30, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants