Changed volume uploader pod image pull policy to "Always" #2852
Conversation
|
Hi @luciantin. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2852 +/- ##
==========================================
+ Coverage 62.66% 63.47% +0.80%
==========================================
Files 127 127
Lines 15570 15571 +1
==========================================
+ Hits 9757 9883 +126
+ Misses 4900 4746 -154
- Partials 913 942 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the contribution! /ok-to-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luciantin, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind bug
Fixes #2835
Default image pull policy was "IfNotPresent", therefore the image would be pulled only once, unless manually changed, and builds would not pull new updated images.
Problem described in #2835 (comment).
Solved by changing the image pull policy of the volume-uploader pod only.
As the volume uploader pod runs before any tasks in https://github.com/knative/func/blob/main/pkg/pipelines/tekton/tasks.go, if the tasks use the default func-utils:v2 image, then those pods will also use the latest image.
Release Note