Fix non-containerized build/run with external deps #2847
Conversation
It's necessary to call "go mod tidy" on scaffolded code. Signed-off-by: Matej Vašek <mvasek@redhat.com>
| @@ -124,6 +123,20 @@ func runGo(ctx context.Context, job *Job) (err error) { | |||
| return | |||
| } | |||
|
|
|||
| // Build | |||
There was a problem hiding this comment.
Diff is little bit confusing here, the code below is actually not added code, but the old code.
The code above that looks unchanged is the actual addition here.
There was a problem hiding this comment.
difftastic IS AWESOME!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2847 +/- ##
==========================================
+ Coverage 60.93% 63.46% +2.53%
==========================================
Files 127 127
Lines 15549 15570 +21
==========================================
+ Hits 9475 9882 +407
+ Misses 5187 4746 -441
- Partials 887 942 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PTAL @jrangelramos @gauron99 |
|
fixes #2846 |
|
PTAL @lkingland |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Fix non-containerized build/run with external deps.
It's necessary to call "go mod tidy" on scaffolded code.
fixes #2846
/kind bug