The committers listed above are authorized under a signed CLA.

• ✅ login: luciantin / name: Tin (b7ec376)

Welcome @luciantin! It looks like this is your first PR to knative/func 🎉

Hi @luciantin. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Some more info to help reproduce the errors.

When using buildpack to build Go on an ARM64 host, the Tekton "prepare" and "results" steps fail with:

Error executing command: fork/exec /tekton/scripts/script-0-....: exec format error

Running the image in docker :

$ docker run --rm -it docker.io/library/bash:5.1.4@sha256:b208215a4655538be652b2769d82e576bc4d0a2bb132144c060efc5be8c3f5d6 sh

Unable to find image 'bash:5.1.4@sha256:b208215a4655538be652b2769d82e576bc4d0a2bb132144c060efc5be8c3f5d6' locally
docker.io/library/bash@sha256:b208215a4655538be652b2769d82e576bc4d0a2bb132144c060efc5be8c3f5d6: Pulling from library/bash
801bfaa63ef2: Pull complete
19e45ec58f41: Pull complete
6435bc57893e: Pull complete
Digest: sha256:b208215a4655538be652b2769d82e576bc4d0a2bb132144c060efc5be8c3f5d6
Status: Downloaded newer image for bash@sha256:b208215a4655538be652b2769d82e576bc4d0a2bb132144c060efc5be8c3f5d6
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
exec /usr/local/bin/docker-entrypoint.sh: exec format error

Solution was to untag the following images :

Fyi

Running the 'TarImage' and 'FuncUtilImage' from main branch, i.e. "ghcr.io/knative/func-utils:v2"

Such as :

kubectl run func-shell --rm -it \
  --image=ghcr.io/knative/func-utils:v2 \
  -- sh

Or the specific arm64 :

kubectl run func-shell --rm -it \
  --image=ghcr.io/knative/func-utils:v2@sha256:d26fc93fa14f3f1fe34cc1b320676dbbeed9b4ff662de44146f92ba856b2e02b \
  -- sh

Both return :

exec /sh: exec format error                                                                                                              
stream closed EOF for default/func-shell (func-shell) 

The image that is used is :
ID: ghcr.io/knative/func-utils@sha256:45b3f8f66d354585c78ac290f723de264d42c857da737e620c5b314ad3610cdf

I confirmed that k8s deployed the specific image, also tried on an ARM64 instance with Docker :

$ docker run --rm -it ghcr.io/knative/func-utils:v2@sha256:d26fc93fa14f3f1fe34cc1b320676dbbeed9b4ff662de44146f92ba856b2e02b sh

Unable to find image 'ghcr.io/knative/func-utils:v2@sha256:d26fc93fa14f3f1fe34cc1b320676dbbeed9b4ff662de44146f92ba856b2e02b' locally
ghcr.io/knative/func-utils@sha256:d26fc93fa14f3f1fe34cc1b320676dbbeed9b4ff662de44146f92ba856b2e02b: Pulling from knative/func-utils
ff0713626554: Pull complete
63e7b8aa440c: Pull complete
Digest: sha256:d26fc93fa14f3f1fe34cc1b320676dbbeed9b4ff662de44146f92ba856b2e02b
Status: Downloaded newer image for ghcr.io/knative/func-utils@sha256:d26fc93fa14f3f1fe34cc1b320676dbbeed9b4ff662de44146f92ba856b2e02b
exec /sh: exec format error

The working one I am using is from branch 'release-1.17' -> 'ghcr.io/knative/func-utils:latest'

https://github.com/luciantin/func-dev/blob/02912c0dc8860c33a56bfbdaa160b735e577936a/pkg/k8s/persistent_volumes.go#L70

As far as the volume-uploader image is concerned, my conclusion is that the ARM64 image does not work on ARM64
https://github.com/knative/func/pkgs/container/func-utils/424105624?tag=v2

Havent looked further, might be tied to kubernetes-sigs/metrics-server#882

Not included in pull, prob should be fixed on the image building side, havent looked yet, but func wont deploy functions on ARM64 with the latest v2 version.

Also, the main branch deploys functions correctly, on ARM64 through buildpack, after the following images are reverted (including the changes in the PR), no other changes were necessary.
(probably also kills s2i if volume-uploader image isnt working)

I can look it up if you'd like, and add it to the PR (if its in the same repo, idk...)

ghcr.io/knative/func-utils:v2 is definitely mullti-arch.

But for whatever reason it contains amd64 binary, weird.

Also note that sh in func image is not really a shell.
See:

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.49%. Comparing base (0ce5759) to head (b7ec376).
Report is 5 commits behind head on main.

@@            Coverage Diff             @@
##             main    #2842      +/-   ##
==========================================
+ Coverage   62.66%   63.49%   +0.82%     
==========================================
  Files         127      127              
  Lines       15545    15545              
==========================================
+ Hits         9742     9870     +128     
+ Misses       4892     4736     -156     
- Partials      911      939      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

OK I know where the problem is 🤦‍♂️ .
I updated the func-util image manually now. I will create PR latter.

#2843

@luciantin The failing test is not your fault. Please just rebase to include fix for it.

/ok-to-test
/approve
/lgtm

@lkingland @dsimansk please override the failing test if possible.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luciantin, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/lgtm