Improvements for Go s2i assembler #2765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Return error code when compilation was not done * Run `go mod tidy` on scaffoded code Signed-off-by: Matej Vašek <mvasek@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2765 +/- ##
==========================================
+ Coverage 61.60% 62.46% +0.85%
==========================================
Files 131 131
Lines 15764 15764
==========================================
+ Hits 9712 9847 +135
+ Misses 5142 4979 -163
- Partials 910 938 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gauron99
approved these changes
Apr 2, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
matejvasek
added a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Apr 4, 2025
* Return error code when compilation was not done * Run `go mod tidy` on scaffoded code Signed-off-by: Matej Vašek <mvasek@redhat.com>
matejvasek
added a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Apr 4, 2025
* Return error code when compilation was not done * Run `go mod tidy` on scaffoded code Signed-off-by: Matej Vašek <mvasek@redhat.com>
openshift-merge-bot bot
pushed a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Apr 4, 2025
* Fix http port 433 => 443 (knative#2742) * Trust loopback builders (knative#2750) Signed-off-by: Matej Vašek <mvasek@redhat.com> * Add testcase for Go private repositories (knative#2748) Signed-off-by: Matej Vašek <mvasek@redhat.com> * Test adjustments (knative#2751) * Use tiny instead of base BP builder. * Decrease minimal required Go version. * Make the self-signed certificate CA==true so it works with update-ca-trust utility. Signed-off-by: Matej Vašek <mvasek@redhat.com> * Allow host mounts for build phahse (knative#2753) * Allow host mounts for build pahse. This is in particular useful for using paket bindings, e.g. to inject git credentials into build process. Signed-off-by: Matej Vašek <mvasek@redhat.com> * Mark test as a integration test Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup: style Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Use s2i in standard mode, not "as-dockerfile" (knative#2764) Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com> * fixup cherry-pick The release-v1.16 branch uses older docker library version some minor adjusment was needed. Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Improvements for Go s2i assembler (knative#2765) * Return error code when compilation was not done * Run `go mod tidy` on scaffoded code Signed-off-by: Matej Vašek <mvasek@redhat.com> * S2I (source-to-image) host binds (knative#2766) * Added tests for s2i build with private Go module The test is for now skipped since host binds are not yet implemented for s2i. Signed-off-by: Matej Vašek <mvasek@redhat.com> * User "host" network mode for s2i build on Linux Signed-off-by: Matej Vašek <mvasek@redhat.com> * Implement host binds for local s2i build Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> * Make build binds more similar to runtime binds (knative#2768) * Make build binds more similar to runtime binds Signed-off-by: Matej Vašek <mvasek@redhat.com> * Added comments on struct Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Add guideline for private Go module usage (knative#2771) Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Fix: Go scaffolding uses correct module name (knative#2769) * Fix: Go scaffolding uses correct module name Using incorrect name works for a functions with flat structure -- no sub-packages. When sub-packages are used we need to refer the user module by its true name. Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup tests Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup for c841f40 Signed-off-by: Matej Vašek <matejvasek@gmail.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
go mod tidyon scaffoded code/kind bug