Skip to content

Fix client-pkg import paths #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2024
Merged

Fix client-pkg import paths #1931

merged 2 commits into from
Mar 27, 2024

Conversation

dsimansk
Copy link
Contributor

Description

Changes

  • Fix client-pkg import paths

PTAL a follow-up on recent cleanups in the client-pkg.
/cc @cardil

Reference

Fixes #

Release Note

Fix client-pkg import paths

@knative-prow knative-prow bot requested a review from cardil March 27, 2024 16:20
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
knative-prow[bot]
knative-prow bot reviewed Mar 27, 2024
View reviewed changes
Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsimansk: 0 warnings.

In response to this:

Description

Changes

  • Fix client-pkg import paths

PTAL a follow-up on recent cleanups in the client-pkg.
/cc @cardil

Reference

Fixes #

Release Note

Fix client-pkg import paths

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 27, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (5c152bd) to head (cd159ce).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1931   +/-   ##
=======================================
  Coverage   74.58%   74.58%           
=======================================
  Files         207      207           
  Lines       15567    15567           
=======================================
  Hits        11611    11611           
  Misses       3167     3167           
  Partials      789      789

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit cbb6f5c into knative:main Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow knative-prow[bot] knative-prow[bot] left review comments

@cardil cardil cardil approved these changes

Assignees

@dprotaso dprotaso

@cardil cardil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsimansk @dprotaso @cardil