Skip to content

fix: Fix deprecated ServiceName in revision describe test #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2021
Merged

fix: Fix deprecated ServiceName in revision describe test #1208

merged 1 commit into from
Jan 28, 2021

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Jan 28, 2021 •
edited
Loading

Description

This fix should unblock auto-upgrade PR that's changing RevisionStatus.ServiceName to *.DeprecatedServiceName. It seems to have no value in the affected unit test.

https://github.com/knative/client/pull/1207/files#diff-000f7df82089c9fe1ae3991339f7742aa78447291609f99bd15fc4ac3a71996fR122-R132

Changes

  • Remove deprecated field from unit tests

Reference

Unblocks #1207

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 28, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2021
@dsimansk dsimansk mentioned this pull request Jan 28, 2021
Merged
@dsimansk
Copy link
Contributor Author 

 Error from server (InternalError): error when creating "https://storage.googleapis.com/knative-releases/eventing/previous/v0.20.0/eventing.yaml": Internal error occurred: failed calling webhook "config.webhook.eventing.knative.dev": Post https://eventing-webhook.knative-eventing.svc:443/config-validation?timeout=2s: no endpoints available for service "eventing-webhook"
Waiting until all pods in namespace knative-eventing are up......................................................................................................................................................
ERROR: timeout waiting for pods to come up

/test pull-knative-client-integration-tests-latest-release

maximilien
maximilien approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 28, 2021
@knative-prow-robot knative-prow-robot merged commit 5b7586b into knative:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppforlife cppforlife Awaiting requested review from cppforlife

@sixolet sixolet Awaiting requested review from sixolet

1 more reviewer

@maximilien maximilien maximilien approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@maximilien maximilien

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsimansk @knative-prow-robot @maximilien