Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Remove KafkaChannel v1alpha1 #550

Merged
merged 5 commits into from
Apr 20, 2021
Merged

Remove KafkaChannel v1alpha1 #550

merged 5 commits into from
Apr 20, 2021

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Apr 19, 2021 •
edited
Loading

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Fixes #71 and #426

Proposed Changes

  • 🗑️ Remove KafkaChannel v1alpha1
  • 🗑️ Cleanup migration script

Release Note

:wastebasket: Remove KafkaChannel v1alpha1
:wastebasket: Cleanup migration script

@slinkydeveloper
Cleanup v1alpha1
cc095ea 
Cleanup migration script

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper requested review from a team as code owners April 19, 2021 13:46
@slinkydeveloper slinkydeveloper requested review from a team April 19, 2021 13:46
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 19, 2021
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 19, 2021
@codecov
Copy link

codecov bot commented Apr 19, 2021 •
edited
Loading

Codecov Report

Merging #550 (b707c79) into main (2b185a9) will decrease coverage by 1.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   72.07%   70.50%   -1.57%     
==========================================
  Files         148      136      -12     
  Lines        5983     5519     -464     
==========================================
- Hits         4312     3891     -421     
+ Misses       1416     1394      -22     
+ Partials      255      234      -21
Impacted Files Coverage Δ
pkg/apis/duck/v1alpha1/placement_types.go
pkg/apis/duck/v1alpha1/register.go
test/upgrade/continual.go 27.71% <0.00%> (+11.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b185a9...b707c79. Read the comment docs.

@slinkydeveloper slinkydeveloper linked an issue Apr 19, 2021 that may be closed by this pull request
Remove usage of eventing duck v1alpha1 shapes #426
Closed
@slinkydeveloper
Remove postinstall setup
dfe440e 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Fix bash
3b2e8ff 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Another fix
fdf52b6 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Nit
b707c79 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Copy link
Contributor Author

/cc @matzew this one is ready for the review

@knative-prow-robot
Copy link
Contributor

@slinkydeveloper: GitHub didn't allow me to request PR reviews from the following users: review, this, one, is, ready, for, the.

Note that only knative-sandbox members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @matzew this one is ready for the review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

matzew
matzew approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@cardil since you recently added some of the upgrade works. Mind having a look here too for giving the final /lgtm ?

Thanks Slinky!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2021
@knative-prow-robot knative-prow-robot merged commit ec6ed51 into knative-extensions:main Apr 20, 2021
@matzew matzew mentioned this pull request Apr 29, 2021
Closed
3 tasks
@pierDipi pierDipi mentioned this pull request Oct 4, 2021
Closed
matzew pushed a commit to matzew/eventing-kafka that referenced this pull request Feb 15, 2022
@openshift-cherrypick-robot @devguyio
rename SO compatibility job (knative-extensions#550)
5299591 
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@matzew matzew matzew approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove usage of eventing duck v1alpha1 shapes Remove KafkaChannel v1alpha1 API shape
3 participants
@slinkydeveloper @knative-prow-robot @matzew