Skip to content

Multiple SMTP servers #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 11, 2025
Merged

Multiple SMTP servers #2290

merged 7 commits into from
Feb 11, 2025

Conversation

lcd1232
Copy link
Contributor

@lcd1232 lcd1232 commented Feb 4, 2025 •
edited
Loading

  • Allows to choose SMTP server per campaign
  • Adds ability to name your SMTP server

Closes #1703

Screenshots

image image

@knadh
Copy link
Owner

knadh commented Feb 5, 2025

Thanks @lcd1232. This is nice. I'll review and test this in the next couple of weeks and consider it for the upcoming release. This has been a long pending request from many users.

@knadh knadh self-assigned this Feb 5, 2025
@knadh
Refactor and simplify SMTP-messenger logic.
f6c6588 
- Make email messenger accept a name and remove any logic from within it.
- Refactor SMTP and and messenger init for consistency.
- Refactor app.messengers to be a slice[] and not map to remove superfluous
  sorting logic.
- Refactor SMTP settings and move the new name field to the bottom to not
  break familiarity.
- Refactor campaign form to print email messengers as a sub <optgroup> of the
  main messenger.
- Init all individual e-mail messengers as `email / $name`.
- Remove unrelated compose file.
@knadh
Copy link
Owner

knadh commented Feb 10, 2025

@lcd1232, I've added a few changes to the PR: f6c6588

Please take a look. I think this is good to be merged now.

lcd1232
lcd1232 commented Feb 10, 2025
View reviewed changes
lcd1232
lcd1232 commented Feb 10, 2025
View reviewed changes
lcd1232
lcd1232 commented Feb 10, 2025
View reviewed changes
lcd1232
lcd1232 commented Feb 10, 2025
View reviewed changes
@lcd1232
Copy link
Contributor Author

lcd1232 commented Feb 10, 2025

@knadh added some comments. Other than that it looks good

@knadh knadh merged commit d055cc5 into knadh:master Feb 11, 2025
@knadh knadh mentioned this pull request Feb 11, 2025
Closed
ai-armageddon pushed a commit to Twitter-outreach/ListMonk that referenced this pull request Mar 11, 2025
@lcd1232 @knadh
Add support for selecting SMTP per campaign (knadh#2290)
dafc89f 
This patch adds a new optional `name` field to SMTP server config on the UI.
When a name is given to an SMTP server, it's initialized as a standalone messenger
which shows up as a sub-group item under the main "email" messenger
on the campaign page.

Co-authored-by: Kailash Nadh <kailash@nadh.in>
Bowrna pushed a commit to Bowrna/listmonk that referenced this pull request Apr 6, 2025
@lcd1232 @knadh @Bowrna
Add support for selecting SMTP per campaign (knadh#2290)
3a93ba0 
This patch adds a new optional `name` field to SMTP server config on the UI.
When a name is given to an SMTP server, it's initialized as a standalone messenger
which shows up as a sub-group item under the main "email" messenger
on the campaign page.

Co-authored-by: Kailash Nadh <kailash@nadh.in>
@Domysee
Copy link

Domysee commented Jun 18, 2025

I was just looking for this feature and found the PR. Just want to say thank you @knadh @lcd1232!!

@violoncelloCH
Copy link
Contributor

Hi, thanks for this implementation!
However I think that this implementation leads to problems if used as described in the request: #1703 . Specifically, if one of the configured SMTP servers does not accept sending mails for the default address (which most likely is the case if this is a SMTP server only used for a specific campaign), then this leads to errors when sending system mails (which use the default sender address), or whenever sending a campaign with the default "email" messenger.
I think, this needs to be extended with a way to specify default SMTP server(s), so that one can add additional ones which are not used by default, but only when specifically selected. UI-wise I think it could even make sense to allow to configure multiple groups of SMTP servers, as suggested in #1703 (comment)
@knadh Should I open a new issue for this?

@violoncelloCH violoncelloCH mentioned this pull request Jun 29, 2025
Open
@lcd1232 lcd1232 deleted the multiple-smtp-servers branch July 3, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knadh knadh knadh left review comments

Assignees

@knadh knadh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pick an SMTP server per campaign
4 participants
@lcd1232 @knadh @Domysee @violoncelloCH