Add support for Postmark bounce notifications via webhooks #1385
Conversation
|
Thank you for the PR, @tosie. I'll review this in the next couple of weeks for the upcoming release. |
|
PR looks good @tosie. One minor correction. The upcoming version is |
Done ✅ |
|
Thanks! Tested this. Was reviewing the Postmark docs before merging and realised that it supports HTTP BasicAuth for webhooks. Without this, the current implementation would be open to abuse (unauthenticated POST). |
|
You are right. I would try to add that, but might need help with the translations … |
|
Hi @tosie. I've been experimenting with GPT-4 auto-translating missing strings in language packs using English as the base. The results are pretty good. Will finish this script and bundle in the repo soon. You can add just the English strings and leave it. |
0149b69 to
72e34f0
Compare
|
This PR is getting big, @knadh :-). Basic auth for Postmark webhooks is implemented now. You can take another look, if you'd like to. |
72e34f0 to
76bdd0b
Compare
|
Rebased on current master. |
|
I'd made a few changes to this PR last week. Only got time to finish it just now. Could you please take a look? 0289c01 |
76bdd0b to
fe5c409
Compare
|
Your commit removes the HTTP basic auth handler completely. I'll try to re-add that to the |
|
Ah, my bad. Added it here: a96b243 |
|
Looks good 👍. Thanks! |
|
Closed in favor of #1485. |
Co-authored-by: Thomas Siebers <tom@tsiebers.de>
Please excuse me from not posting a feature issue first. The implementation was not that much work and I felt it would be easier to just write code and talk about that.
This PR adds support for Postmark's bounce notifications.
Currently, Listmonk has support for SES and Sendgrid bounce notifications. I use Postmark and would like to use Listmonk, so it made sense to contribute something to this project that might be beneficial for other users, too.
There are two main areas of this PR:
There is also a migration (v2.6.0) that adds the setting key to the DB.