Skip to content

Use Go 1.17 for fixed size copying #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Use Go 1.17 for fixed size copying #424

wants to merge 2 commits into from

Conversation

klauspost
Copy link
Owner

@klauspost klauspost commented Aug 24, 2021 •
edited
Loading

Experiment. Checking if worth it.

benchmark                                          old ns/op     new ns/op     delta 
BenchmarkDecompress4XTable/digits-32               171211        163020        -4.78%
BenchmarkDecompress4XTable/gettysburg-32           4045          3938          -2.65%
BenchmarkDecompress4XTable/twain-32                585484        567582        -3.06%
BenchmarkDecompress4XTable/low-ent.10k-32          57526         57130         -0.69%
BenchmarkDecompress4XTable/superlow-ent-10k-32     15864         15675         -1.19%
BenchmarkDecompress4XTable/case1-32                2003          2023          +1.00%
BenchmarkDecompress4XTable/case2-32                1993          1982          -0.55%
BenchmarkDecompress4XTable/case3-32                1987          2026          +1.96%
BenchmarkDecompress4XTable/pngdata.001-32          82474         78583         -4.72%
BenchmarkDecompress4XTable/normcount2-32           1377          1329          -3.49%
                                                                                     
benchmark                                          old MB/s     new MB/s     speedup 
BenchmarkDecompress4XTable/digits-32               584.09       613.44       1.05x   
BenchmarkDecompress4XTable/gettysburg-32           382.67       393.10       1.03x   
BenchmarkDecompress4XTable/twain-32                447.74       461.86       1.03x   
BenchmarkDecompress4XTable/low-ent.10k-32          695.34       700.16       1.01x   
BenchmarkDecompress4XTable/superlow-ent-10k-32     661.86       669.84       1.01x   
BenchmarkDecompress4XTable/case1-32                27.46        27.18        0.99x   
BenchmarkDecompress4XTable/case2-32                22.58        22.70        1.01x   
BenchmarkDecompress4XTable/case3-32                24.16        23.69        0.98x   
BenchmarkDecompress4XTable/pngdata.001-32          620.80       651.54       1.05x   
BenchmarkDecompress4XTable/normcount2-32           63.18        65.48        1.04x

@orijbot
Copy link

orijbot commented Sep 3, 2021

Visit https://dashboard.github.orijtech.com?back=0&pr=424&remote=false&repo=klauspost%2Fcompress to see benchmark details.

klauspost added a commit that referenced this pull request Sep 8, 2022
@klauspost
Use arrays for constant size copies
099f285 
Requires Go 1.17

Replaces #424
@klauspost klauspost mentioned this pull request Sep 8, 2022
Merged
@klauspost klauspost closed this Sep 9, 2022
@klauspost klauspost deleted the go117-copies branch March 11, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klauspost @orijbot