Allow providing config values only via environment #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes add a new `NoFile` option and the new `fig.ignoreFile` field. Giving this option to `Load()` will: - Disable the default file lookup process - The `File` and `Dir` option still work as before but become ineffective in the presence of `NoFile` option. Signed-off-by: Ravi Shekhar Jethani <rsjethani@gmail.com>
|
Addresses #5 |
|
Thanks for the PR! I'll allocate some time to go over it in the next few days. |
kkyr
requested changes
Nov 15, 2021
fig.go
Outdated
| if err != nil { | ||
| return err | ||
| if !f.ignoreFile { | ||
|
|
fig_test.go
Outdated
| @@ -405,6 +405,66 @@ func Test_fig_Load_WithOptions(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func Test_fig_Load_NoFile(t *testing.T) { | |||
| t.Run("NOFILE", func(t *testing.T) { | |||
option.go
Outdated
| // config values only via environment variables. | ||
| // | ||
| // fig.Load(&cfg, fig.NoFile(), fig.UseEnv("my_app")) | ||
| func NoFile() Option { |
There was a problem hiding this comment.
I believe IgnoreFile would be a more descriptive name here, since we're telling fig to actually ignore the file (even if it exists).
option.go
Outdated
| @@ -18,6 +18,19 @@ func File(name string) Option { | |||
| } | |||
| } | |||
|
|
|||
| // NoFile returns an option which disables any file lookup | |||
|
Thanks for the review, changes added |
|
Please also add a description to |
|
updated docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes add a new
NoFileoption and the newfig.ignoreFilefield.Giving this option to
Load()will:FileandDiroption still work as before butbecome ineffective in the presence of
NoFileoption.Signed-off-by: Ravi Shekhar Jethani rsjethani@gmail.com