Recursively join text nodes inside links, images, and wikilinks #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much! I'll fuzz it for a while and merge assuming all good. :) |
|
No problem, and thank you too. Your pointers made it easy to make the change. |
|
@kivikakk Thanks for merging this. Would it be possible to cut a |
|
Done! Thanks for the report and bugfix! 😊 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously link, image, and wikilink nodes were not recursively parsed to join text nodes. This change adds
in_bracket_contextto recursively join text nodes but avoids generating nested autolinks.Related: gjtorikian/commonmarker#376