Skip to content

Conversation

digitalmoksha
Copy link
Collaborator

This addresses #558. Fixes a problem where task list items that starts with an inline node other than text that does not render.

Example:

- [ ] `code`

@digitalmoksha digitalmoksha merged commit 719a162 into main Apr 5, 2025
45 checks passed
@digitalmoksha digitalmoksha deleted the fix-tasklist-handling branch April 5, 2025 01:38
Copy link
Contributor

github-actions bot commented Apr 5, 2025

Command Mean [ms] Min [ms] Max [ms] Relative
./bench.sh ./comrak-8b19d89 318.7 ± 2.3 315.4 326.5 2.93 ± 0.03
./bench.sh ./comrak-main 322.3 ± 7.4 318.1 353.9 2.96 ± 0.07
./bench.sh ./pulldown-cmark 108.8 ± 0.6 107.7 110.3 1.00
./bench.sh ./cmark-gfm 115.0 ± 1.4 112.9 118.5 1.06 ± 0.01
./bench.sh ./markdown-it 481.1 ± 6.9 476.8 510.5 4.42 ± 0.07

Run on Sat Apr 5 01:39:07 UTC 2025

@digitalmoksha
Copy link
Collaborator Author

@kivikakk This should fix #558. We should probably cut another release.

@kivikakk
Copy link
Owner

kivikakk commented Apr 5, 2025

Thanks, @digitalmoksha, this looks good. I'm going to run fuzzing for a couple hours here first (just because I found all those ridiculous echaw test cases in tasklists through fuzzing, and the sourcepos handling stuff there was no end of failing asserts), then will release. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants