Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kisielk/errcheck
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.6.1
Choose a base ref
...
head repository: kisielk/errcheck
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.6.2
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Jul 8, 2022

  1. Calculate correct position with comments before the package keyword

    Detect the file beginning by using `pass.Fset.File(f.Pos())` instead of
    assuming that `f.Pos()` is always the beginning of the file.
    
    `f.Pos()` is not the beginning of the file when there is for instance a
    comment before the package, which can lead to wrong reportings of the
    actual error position.
    
    Signed-off-by: Roman Mohr <rmohr@google.com>
    rmohr committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    875db03 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. Merge pull request #215 from rmohr/comments-before-package

    Calculate correct position with comments before the package keyword
    kisielk authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    3faf0bc View commit details
    Browse the repository at this point in the history
Loading