Skip to content

Upgrade sass #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 29, 2021
Merged

Upgrade sass #96

merged 4 commits into from
Sep 29, 2021

Conversation

roythearsonist
Copy link
Contributor

Motivation

As an avowed sass user, I was heartbroken to see a deprecated version of as being used. This pr fixes that issue

Changes

Update to sass, the maintained version of node-sass.

Additional Comments

Sorry for not updating the lock file, it wasn't working for some reason.

@vercel
Copy link

vercel bot commented Sep 28, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel.

@kimlimjustin first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 29, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/4QJZuoWkMGFrkHbaD6wt9MFTiUbo
✅ Preview: https://xplorer-git-fork-theblobscp-upgrade-sass-kimlimjustin.vercel.app

kimlimjustin
kimlimjustin requested changes Sep 29, 2021
View reviewed changes
Copy link
Owner

@kimlimjustin kimlimjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out! I'm not a fan of sass so yeah hehe...

Btw, It seems like you forgot to commit the yarn.lock file, it's a necessary tho if you update the dependencies, but yeah, I'll commit it.

TYSM

@kimlimjustin kimlimjustin merged commit f160e5a into kimlimjustin:master Sep 29, 2021
@roythearsonist
Copy link
Contributor Author

Btw, It seems like you forgot to commit the yarn.lock file, it's a necessary tho if you update the dependencies, but yeah, I'll commit it.

Under additional comments, I said that it didn't work on my machine. Sorry about that.

@roythearsonist roythearsonist deleted the upgrade-sass branch September 29, 2021 12:49
@kimlimjustin
Copy link
Owner

Ah okay, thanks tho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimlimjustin kimlimjustin kimlimjustin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roythearsonist @kimlimjustin