Skip to content

Added french translation #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2021
Merged

Added french translation #91

merged 2 commits into from
Sep 28, 2021

Conversation

thomasbnt
Copy link
Contributor

Motivation

I appreciate the project. I would like to contribute with my language 😄

Changes

Added French translation.

Related

#30 (comment)

@vercel
Copy link

vercel bot commented Sep 28, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel.

@kimlimjustin first needs to authorize it.

kimlimjustin
kimlimjustin requested changes Sep 28, 2021
View reviewed changes
Copy link
Owner

@kimlimjustin kimlimjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you are supposed to do it via Crowdin (#30), but yeah it's okay if you done this manually.

I think you forgot a step, to edit the src/Locales/index.json, add your language into the availableLanguages. If you don't know how: just follow this guide:

Add property into the availableLanguges object with the following criteria:

  • the key should be your language in your language, for example: English, 中文, french is francais if I do not remember it wrongly, is it?
  • the value should be your language code, in this case, fr-FR

Thanks!

@thomasbnt
Copy link
Contributor Author

Yeah sorry I started to contribute on Crowdin, but I see the Locales/ folder. I supposed to contribute directly with the new file. At the same time I read the #30 😅😂

kimlimjustin
kimlimjustin approved these changes Sep 28, 2021
View reviewed changes
Copy link
Owner

@kimlimjustin kimlimjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, Thanks!

@vercel
Copy link

vercel bot commented Sep 28, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/GDpmaoBWJt5kWZGkccftYvyhUJRT
✅ Preview: https://xplorer-git-fork-thomasbnt-added-french-tra-22d93a-kimlimjustin.vercel.app

@kimlimjustin kimlimjustin merged commit 10fb338 into kimlimjustin:master Sep 28, 2021
@thomasbnt thomasbnt mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimlimjustin kimlimjustin kimlimjustin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasbnt @kimlimjustin