-
-
Notifications
You must be signed in to change notification settings - Fork 347
feat: Gitpod Support #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Configuration for the Gitpod Session
Adding the server file which automates most of the process, all the user needs to do is choose between app and docs.
Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel. @kimlimjustin first needs to authorize it. |
@kimlimjustin here it is, there's not any kind of big commit activities at all in this. |
Don't merge this until the documentation is updated with the latest info of this. |
Did you tried on this, and is it works? (since I have no experience with it) |
Okay sure |
I have to, I will check it now. Forgot about that 😅 |
It doesn't seem to work, but don't worry, I will try simple workarounds like running both servers, the workspace won't slow down and you have a choice to choose between app and docs as always. I will make a Gitpod guide file for the contributor that will open immediately after loading up. |
By moving the code _here_ from _there_, the code can work without flaws, and you can kill the terminal process if you want.
Since the code is already implemented in the Gitpod Config, this is of no use as of now.
Add Gitpod code for button and add specific section.
Alright, I'd like to call it a day. Last comment for today for me: I added the Gitpod part in the Contributing guide for the website, and am aiming to merge it here so that you don't need to merge two PRs here, I will bundle everything into one package so that you can merge a lot of things immediately. |
Add a specific Development section with Gitpod included.
Add docs for Gitpod. Tested this and it is loaded up on the Contributing page.
@kimlimjustin I have added documentation for Gitpod on the Contributing guide page on the Xplorer site and the README, as a shortcut. Now, I tested the docs but I have to test the app's server, which I will do later. |
I noticed that there are grammatical mistakes in the docs, so I will fix them inside this. Remember to add a description of all the changes so that users can know what has happened. |
Correct grmmatical errors and add some more info and clarity.
Fix Markdown syntax error by replacing ` ` ` with `<kbd></kbd>`
PS: Can you allow Vercel for the test deployment? I need to see how the website is right here. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/Qfe9FVC8PwjejkaeJqovPk97dUd8 |
Done |
@kimlimjustin it works! The noVNC does work now! Posting a video recording of it later, since I need to set up OBS, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It really works like a charm! TYSM!
I have a genuine Xplorer suggestion. Can you try adding some space between buttons? Since I have become used to the Material You and Fluent Design theming where they put some space between buttons, I think if you put some space between the button, it might look neater. Also, try changing the font to Google Sans or something similar that looks flat as well as beautiful. |
Excellent! Other than Vercel, everything has succeeded. |
WDYM by space between buttons, could you give a screenshot or something, for the font family, it uses the system font as default, but user will be able to customize it by their own (I'm currently working it, you can see branch theme_customization) |
I am trying to mean that can you give some space between buttons like 2
pixels or more so that with the spacing, it looks neater than last time?
Just imagine, if you stack a cluttered desk and make it neater by adding
space between everything, you yourself will feel that this was neater than
before, right? That is what I am asking for Xplorer, some more neatness. If
you see the Files UX app on Windows, you will think it is very neat, since
they added a little bit of space between all the buttons. That was what I
was trying to mean. Try adding some spacing and observe the UI youself, you
can feel that this is really neat.
|
Ah, that's what I meant! This is looking better than before. I couldn't figure out this since I saw the same thing on noVNC 😅 but since the noVNC font was smaller, I couldn't figure it out. |
I also am not sure. Actually, Vercel isn't supposed to fail unless there are issues with the code. Try using the Gitpod link I gave above. To save your time, it is here: #84 (comment) |
Vercel isn't deploying properly. I opened a new Gitpod Workspace based on the link I posted after the recording, and everything is good, everything is fine there, but not here. I'll be right back. |
I think it has to do with the Code of Conduct link inside the support.md file. I will try finding a simple workaround for this, it has to be easy as I think. |
Did you check the logs? I think what I told is the problem. Let me change it here, and regarding Gitpod, the ports code does work, all you need to do is allow popups. Since Gitpod creates randomized links every time you create a new session, you have to allow popups continuously. |
Ah, now try triggering a preview deployment. I think this issue(Code Of Conduct) is fixed as of now. |
Sorry for slow rely (I was having quiz just now), sometimes the docusaurus is indeed buggy, I'll try to fix this |
Ah, it's fine. I think I fixed Docusaurus, try a new deployment and can you try allowing me to analyse the build logs? Since I might find the error, I want to see the log. |
And instead of triggering a deployment, try authorizing Vercel, so that it will automatically trigger on push. |
This could relatively point to the URL, even if it's deployed locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, everything passed, thanks!
@kimlimjustin can you do this when you are free? On the README, I added a very important note there. Can you just copy that and add it to the Gitpod section on the Contributing page on the Xplorer site? I forgot about that, so can you just add that line there? |
important note=under gitpod section |
Okay, I'll add together with another docs after eating :) |
Okay. Everything works nicely now. The Vercel deployment didn't fail, so it was the broken link, which is fixed now. Everything loads exactly as I hoped. I am waiting for a new release and new contributors. Try making a Gitpod Remarks discussion where people can tell any kind of bugs on Gitpod and I will be there to fix it. Since I am (kinda) a Gitpod expert, I could help on it here. |
Thanks, I think the next version (0.2.0) will be released next month since I have to deal with so many items, like the customization (which I'm doing rn) and the issues (you can help if you want to xd) |
I'd love to! Maybe I can test it via VNC on Gitpod and give my feedback
here, that'd be cool xD
|
Thanks! |
Motivation
Info on #83
Changes
Added Gitpod Dockerfile+Config
Added Server Shell script for automation.Related
#83 #69 has more info than this
Additional Comments
Must modify docs, CONTRIBUTING.md and README.md