-
-
Notifications
You must be signed in to change notification settings - Fork 347
update: enhance version page #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: enhance version page #82
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel. @kimlimjustin first needs to authorize it. |
@kimlimjustin what do you think about this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The design looks good to me
However, I think it would be better if we can add a copy button to each of the versions there (it would be much easier to check the version when submitting a bug report). Could you please add this? If you can't, It's completely Okay, I can add it by myself :)
Thanks
@kimlimjustin thanks for the feedback. I'd be happy to do it. |
I am thinking of two approaches -
Can you tell me which would be best fitted here ? |
I think a copy button beside each entry is better. Ex: The copy button beside the |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/DD9WnKqF1E2rb6wePDJiME6iKbDr |
@kimlimjustin I added "copy to clipboard" button functionality in version page. Can you check it once ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
About/Version page was not looking proper.
Changes
Attached is the screenshot of what changed -