Skip to content

update: enhance version page #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rushabh-wadkar
Copy link
Contributor

Motivation

About/Version page was not looking proper.

Changes

Attached is the screenshot of what changed -

image

@vercel
Copy link

vercel bot commented Sep 27, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel.

@kimlimjustin first needs to authorize it.

@rushabh-wadkar
Copy link
Contributor Author

@kimlimjustin what do you think about this ?

Copy link
Owner

@kimlimjustin kimlimjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design looks good to me

However, I think it would be better if we can add a copy button to each of the versions there (it would be much easier to check the version when submitting a bug report). Could you please add this? If you can't, It's completely Okay, I can add it by myself :)

Thanks

@rushabh-wadkar
Copy link
Contributor Author

@kimlimjustin thanks for the feedback. I'd be happy to do it.

@rushabh-wadkar
Copy link
Contributor Author

I am thinking of two approaches -

  1. Giving a copy button beside each entry (explicit button copy behaviour)
  2. Clicking on each entry would copy it to clipboard directly. Implicit copy behaviour

Can you tell me which would be best fitted here ?

@kimlimjustin
Copy link
Owner

I am thinking of two approaches -

  1. Giving a copy button beside each entry (explicit button copy behaviour)
  2. Clicking on each entry would copy it to clipboard directly. Implicit copy behaviour

Can you tell me which would be best fitted here ?

I think a copy button beside each entry is better. Ex: The copy button beside the OS will copy the number version of OS. Erm, if could why don't just add a big button too, to copy the whole information?

@vercel
Copy link

vercel bot commented Sep 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/DD9WnKqF1E2rb6wePDJiME6iKbDr
✅ Preview: https://xplorer-git-fork-rushabh-wadkar-improvement-8e4b64-kimlimjustin.vercel.app

@rushabh-wadkar
Copy link
Contributor Author

@kimlimjustin I added "copy to clipboard" button functionality in version page. Can you check it once ?

Copy link
Owner

@kimlimjustin kimlimjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimlimjustin kimlimjustin merged commit 266e75a into kimlimjustin:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants