Skip to content

Update Ukrainian translation #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2021
Merged

Update Ukrainian translation #162

merged 1 commit into from
Oct 17, 2021

Conversation

AlexHladin
Copy link
Contributor

Motivation

I saw this

Changes

Translated to Ukrainian for src/Locales and src/i18n. In addition to #155 PR

Related

#30

Additional Comments

#155 #161
(Anything, optional)

@vercel
Copy link

vercel bot commented Oct 16, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel.

@kimlimjustin first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 16, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/ADWgKVWJGHejxKNjVy3QHPvi7QMK
✅ Preview: https://xplorer-git-fork-alexhladin-update-ukrainia-a9f3f4-kimlimjustin.vercel.app

@kimlimjustin
Copy link
Owner

Is this PR ready to merge? Or do you want to add something else? Please let me know ....

@AlexHladin
Copy link
Contributor Author

Is this PR ready to merge? Or do you want to add something else? Please let me know ....

Yes, the PR is ready, but future improvements are possible.

@kimlimjustin
Copy link
Owner

Oh yeah, I think that you forgot the locale of Xplorer itself, located on src/Locales, do you want to add it?

Thanks!

@AlexHladin
Copy link
Contributor Author

AlexHladin commented Oct 16, 2021 •
edited
Loading

Oh yeah, I think that you forgot the locale of Xplorer itself, located on src/Locales, do you want to add it?

Thanks!

The file already have been added in #155 PR

xplorer/src/Locales/uk-UA.json

Line 23 in ab6c88e

"Extract exe file icon and make it as the thumbnail (Turning it on might crashes Xplorer)": "Extract exe file icon and make it as the thumbnail (Turning it on might crashes Xplorer)",

@kimlimjustin kimlimjustin merged commit 9f79a7d into kimlimjustin:master Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimlimjustin kimlimjustin kimlimjustin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexHladin @kimlimjustin