Skip to content

Conversation

javaboy-github
Copy link
Contributor

Motivation

I saw this.

Changes

Translated to Japanese for src/Locales and src/i18n.

Related

#30).

Additional Comments

I couldn't translate all folders. Sorry.

@vercel
Copy link

vercel bot commented Oct 7, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel.

@kimlimjustin first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/BsuW6TALKvEMLQCFAYtrgrNSDQSM
✅ Preview: https://xplorer-git-fork-javaboy-github-master-kimlimjustin.vercel.app

@kimlimjustin
Copy link
Owner

Hello, TYSM for your PR, however, it seems that you only translate parts of the docs, things you haven't done:

  1. Copy and translate the docs folders
  2. You didn't add ja-JP into the docs i18n locales array, see this

I saw your additional comment that you couldn't translate all folders, it's actually okay, however, this will make the Japanese language won't appear on the docs site, only on the Xplorer app (but the translation will be saved and could be completed n the future).

Could you please confirm whether it's okay to merge this PR and make Japanese language appears on Xplorer app and your partial translation of the docs will be saved but not appears on the site, or do you want to add more commits to the docs?

Thanks and Regards,

@javaboy-github
Copy link
Contributor Author

or do you want to add more commits to the docs?

No, I don't. I won't be able to do that as I will be busy for two weeks.

@kimlimjustin kimlimjustin merged commit cd112dc into kimlimjustin:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants