Skip to content

Resolve #70, bug fixes, and small visual adjustments #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 25, 2023
Merged

Resolve #70, bug fixes, and small visual adjustments #81

merged 8 commits into from
Oct 25, 2023

Conversation

hohaicongthuan
Copy link
Contributor

What's changed:

  • Button colours: slightly adjust button colours and add the shadow effect mentioned in buttons that are both pressed and hover should have a shadow effect #70.
  • Progress bar: adjust progress bar colours.
  • Fix tab behaviour: in Windows 7, when an inactive tab is clicked on, it will be switched to active as soon as the mouse button is down so I fixed that. However, the fix that I applied here doesn't distinguish between the left, right, and middle mouse buttons. (I'm not proficient enough in Javascript and I'm too lazy to google for a solution 👀)
  • Fix a tab bug: here's the bug.
    test

@vercel
Copy link

vercel bot commented Oct 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
7css ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 10:56am

khang-nd
khang-nd requested changes Oct 23, 2023
View reviewed changes
Copy link
Owner

@khang-nd khang-nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hohaicongthuan, just some minor points, great stuff as usual.

@khang-nd khang-nd linked an issue Oct 23, 2023 that may be closed by this pull request
buttons that are both pressed and hover should have a shadow effect #70
Closed
@hohaicongthuan
Copy link
Contributor Author

I think it's good now.

khang-nd
khang-nd approved these changes Oct 25, 2023
View reviewed changes
Copy link
Owner

@khang-nd khang-nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, thanks mate!

@khang-nd khang-nd merged commit 2e5e148 into khang-nd:main Oct 25, 2023
@hohaicongthuan hohaicongthuan deleted the dev-adjust-button-colour branch October 28, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khang-nd khang-nd khang-nd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

buttons that are both pressed and hover should have a shadow effect
2 participants
@hohaicongthuan @khang-nd